From e090fc89c022b7e244f98efb25dcd5f3244c09d0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=B6ren=20Weber?= <mail@soeren-weber.de>
Date: Sat, 30 Sep 2023 21:45:39 +0200
Subject: [PATCH] theme: fix id generation for markdownified titles #657

---
 exampleSite/layouts/partials/toc.html            | 2 +-
 layouts/404.html                                 | 2 +-
 layouts/_default/taxonomy.html                   | 4 ++--
 layouts/_default/term.html                       | 2 +-
 layouts/partials/archetypes/chapter/article.html | 2 +-
 layouts/partials/archetypes/default/article.html | 2 +-
 layouts/partials/archetypes/home/article.html    | 2 +-
 layouts/partials/body.searchpage.html            | 2 +-
 layouts/partials/content-footer.html             | 2 +-
 layouts/partials/initial.html                    | 2 +-
 layouts/partials/shortcodes/tabs.html            | 6 +++---
 layouts/partials/tags.html                       | 2 +-
 layouts/partials/toc.html                        | 2 +-
 13 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/exampleSite/layouts/partials/toc.html b/exampleSite/layouts/partials/toc.html
index c4f9a5e527..b9bb92d5c4 100644
--- a/exampleSite/layouts/partials/toc.html
+++ b/exampleSite/layouts/partials/toc.html
@@ -5,7 +5,7 @@
   {{- range .Data.Terms.Alphabetical }}
     {{- $capital := substr .Page.Title 0 1 | upper }}
     {{- if ne $lastCapital $capital }}
-    <li><a href="#{{ $capital | anchorize }}">{{ $capital }}</a></li>
+    <li><a href="#{{ $capital | plainify | anchorize }}">{{ $capital }}</a></li>
     {{- end }}
     {{- $lastCapital = $capital }}
   {{- end }}
diff --git a/layouts/404.html b/layouts/404.html
index 9a870650f9..7391ba39d5 100644
--- a/layouts/404.html
+++ b/layouts/404.html
@@ -67,7 +67,7 @@
         <div class="flex-block-wrapper">
           <article>
             <h1 id="404"><span>4</span>{{ partial "shortcodes/icon.html" (dict "page" . "icon" "far fa-frown" )}}<span>4</span></h1>
-            <h2 id="{{ T "title-404" | anchorize }}">{{ T "title-404" }}</h2>
+            <h2 id="{{ T "title-404" | plainify | anchorize }}">{{ T "title-404" }}</h2>
             <p></p>
             <p>{{ T "message-404" }}</p>
             <p></p>
diff --git a/layouts/_default/taxonomy.html b/layouts/_default/taxonomy.html
index 7186e82301..ef47290246 100644
--- a/layouts/_default/taxonomy.html
+++ b/layouts/_default/taxonomy.html
@@ -9,7 +9,7 @@
 {{- if not $title }}
   {{- $title = .Data.Plural }}
 {{- end }}
-<h1 id="{{ $title | anchorize }}">{{ $title }}</h1>
+<h1 id="{{ $title | plainify | anchorize }}">{{ $title }}</h1>
 {{- $lastCapital := "" }}
 {{- range .Data.Terms.Alphabetical }}
   {{- $capital := substr .Page.Title 0 1 | upper }}
@@ -17,7 +17,7 @@
     {{- if ne $lastCapital "" }}
 </ul>
     {{- end }}
-<h2 id="{{ $capital | anchorize }}">{{ $capital }}</h2>
+<h2 id="{{ $capital | plainify | anchorize }}">{{ $capital }}</h2>
 <ul class="columnize">
   {{- end }}
     {{- $c:=""}}{{/* display terms of a taxonomy */}}
diff --git a/layouts/_default/term.html b/layouts/_default/term.html
index 0f59b55adc..3688c58557 100644
--- a/layouts/_default/term.html
+++ b/layouts/_default/term.html
@@ -10,7 +10,7 @@
   {{- $title = .Data.Singular }}
 {{- end }}
 {{- $title = printf "%s %s %s" $title (default "::" .Site.Params.titleSeparator) .Title }}
-<h1 id="{{ $title | anchorize }}">{{ $title }}</h1>
+<h1 id="{{ $title | plainify | anchorize }}">{{ $title }}</h1>
 <ul class="columnize">
   {{- range sort .Pages "Title" }}
     {{- $c:=""}}{{/* display pages of a term */}}
diff --git a/layouts/partials/archetypes/chapter/article.html b/layouts/partials/archetypes/chapter/article.html
index d391efaea6..a36d250bf5 100644
--- a/layouts/partials/archetypes/chapter/article.html
+++ b/layouts/partials/archetypes/chapter/article.html
@@ -6,7 +6,7 @@
               {{- partial "content-header.html" . }}
             </header>
 {{ partial "heading-pre.html" . }}<div class="article-subheading">{{ T "Chapter" .Params.Weight }}</div>
-<h1 id="{{ .Title | anchorize }}">{{ .Title }}</h1>{{ partial "heading-post.html" . }}
+<h1 id="{{ .Title | plainify | anchorize }}">{{ .Title }}</h1>{{ partial "heading-post.html" . }}
 
 {{ $content | safeHTML }}
             <footer class="footline">
diff --git a/layouts/partials/archetypes/default/article.html b/layouts/partials/archetypes/default/article.html
index f3971ab326..409de441cc 100644
--- a/layouts/partials/archetypes/default/article.html
+++ b/layouts/partials/archetypes/default/article.html
@@ -5,7 +5,7 @@
             <header class="headline">
               {{- partial "content-header.html" . }}
             </header>
-{{ partial "heading-pre.html" . }}<h1 id="{{ .Title | anchorize }}">{{ .Title }}</h1>{{ partial "heading-post.html" . }}
+{{ partial "heading-pre.html" . }}<h1 id="{{ .Title | plainify | anchorize }}">{{ .Title }}</h1>{{ partial "heading-post.html" . }}
 
 {{ $content | safeHTML }}
             <footer class="footline">
diff --git a/layouts/partials/archetypes/home/article.html b/layouts/partials/archetypes/home/article.html
index 09558ff83b..64cfeb57a0 100644
--- a/layouts/partials/archetypes/home/article.html
+++ b/layouts/partials/archetypes/home/article.html
@@ -5,7 +5,7 @@
             <header class="headline">
               {{- partial "content-header.html" . }}
             </header>
-{{ partial "heading-pre.html" . }}<h1 id="{{ .Title | anchorize }}">{{ .Title }}</h1>{{ partial "heading-post.html" . }}
+{{ partial "heading-pre.html" . }}<h1 id="{{ .Title | plainify | anchorize }}">{{ .Title }}</h1>{{ partial "heading-post.html" . }}
 
 {{ $content | safeHTML }}
             <footer class="footline">
diff --git a/layouts/partials/body.searchpage.html b/layouts/partials/body.searchpage.html
index c72a339d95..1c70900835 100644
--- a/layouts/partials/body.searchpage.html
+++ b/layouts/partials/body.searchpage.html
@@ -3,7 +3,7 @@
           <article class="default">
             <header class="headline">
             </header>
-            <h1 id="{{ $title | anchorize }}">{{ $title }}</h1>
+            <h1 id="{{ $title | plainify | anchorize }}">{{ $title }}</h1>
 
             <form action="javascript:triggerSearch()">
               <div class="searchform">
diff --git a/layouts/partials/content-footer.html b/layouts/partials/content-footer.html
index d7411b43be..f3adbbce84 100644
--- a/layouts/partials/content-footer.html
+++ b/layouts/partials/content-footer.html
@@ -9,7 +9,7 @@
               <i class='fas fa-list'></i>
   {{- $categories := slice | append .Params.categories }}
   {{- range $idx, $category := sort $categories }}
-    {{- with $page.Site.GetPage (printf "%s%s" ("/categories/" | relURL ) ( $category | anchorize ) ) }}
+    {{- with $page.Site.GetPage (printf "%s%s" ("/categories/" | relURL ) ( $category | plainify | anchorize ) ) }}
       {{- $to := . }}
               {{ if gt $idx 0 }} | {{ end }}<a class="tag-link" href="{{ partial "relLangPrettyUglyURL.hugo" (dict "to" $to) }}">{{ $category }}</a>
     {{- end }}
diff --git a/layouts/partials/initial.html b/layouts/partials/initial.html
index 434fc1e373..063a492a24 100644
--- a/layouts/partials/initial.html
+++ b/layouts/partials/initial.html
@@ -1,6 +1,6 @@
 {{- if not .Title }}
   {{- $title := .Site.Title }}
-  {{- partial "heading-pre.html" . }}<h1 id="{{ $title | anchorize }}">{{ $title }}</h1>{{ partial "heading-post.html" . }}
+  {{- partial "heading-pre.html" . }}<h1 id="{{ $title | plainify | anchorize }}">{{ $title }}</h1>{{ partial "heading-post.html" . }}
 {{- end }}
 
 {{- "layouts/partials/initial.md" | readFile | .RenderString }}
\ No newline at end of file
diff --git a/layouts/partials/shortcodes/tabs.html b/layouts/partials/shortcodes/tabs.html
index 576d9341fa..3279ce2881 100644
--- a/layouts/partials/shortcodes/tabs.html
+++ b/layouts/partials/shortcodes/tabs.html
@@ -3,8 +3,8 @@
   {{- $page = .context }}
   {{- warnf "%q: DEPRECATED parameter 'context' for shortcode 'tabs' found, use 'page' instead; see https://mcshelby.github.io/hugo-theme-relearn/basics/migration/#5180" $page.File.Path }}
 {{- end }}
-{{- $groupid := .groupid | default (partial "make-random-md5.hugo" $page) | anchorize }}
-{{- $color := .color }}
+{{- $groupid := .groupid | default (partial "make-random-md5.hugo" $page) | plainify | anchorize }}
+ {{- $color := .color }}
 {{- $style := .style }}
 {{- $title := .title }}
 {{- $icon := .icon }}
@@ -34,7 +34,7 @@
       "color"   $color
       "content" .content
       "icon"    $icon
-      "itemid"  (printf "%s%s" ($title | $page.RenderString | anchorize) ($icon | anchorize))
+      "itemid"  (printf "%s%s" ($title | $page.RenderString | plainify | anchorize) ($icon | plainify | anchorize))
       "style"   $style
       "title"   $title
     ) }}
diff --git a/layouts/partials/tags.html b/layouts/partials/tags.html
index 65398689ae..8692267681 100644
--- a/layouts/partials/tags.html
+++ b/layouts/partials/tags.html
@@ -5,7 +5,7 @@
   {{- $tags := slice | append .Params.tags }}
   {{- range sort $tags }}
     {{- $tag := . }}
-    {{- with $page.Site.GetPage (printf "%s%s" ("/tags/" | relURL ) ( $tag | anchorize ) ) }}
+    {{- with $page.Site.GetPage (printf "%s%s" ("/tags/" | relURL ) ( $tag | plainify | anchorize ) ) }}
       {{- $to := . }}
   <a class="tag-link" href="{{ partial "relLangPrettyUglyURL.hugo" (dict "to" $to) }}">{{ $tag }}</a>
     {{- end }}
diff --git a/layouts/partials/toc.html b/layouts/partials/toc.html
index 0c0fcbef1d..de94f5a060 100644
--- a/layouts/partials/toc.html
+++ b/layouts/partials/toc.html
@@ -5,7 +5,7 @@
   {{- range .Data.Terms.Alphabetical }}
     {{- $capital := substr .Page.Title 0 1 | upper }}
     {{- if ne $lastCapital $capital }}
-    <li><a href="#{{ $capital | anchorize }}">{{ $capital }}</a></li>
+    <li><a href="#{{ $capital | plainify | anchorize }}">{{ $capital }}</a></li>
     {{- end }}
     {{- $lastCapital = $capital }}
   {{- end }}