From 460ab79e66bd59ef416b9b4e12d6130de9c573d6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=B6ren=20Weber?= <mail@soeren-weber.de>
Date: Sat, 5 Nov 2022 20:34:57 +0100
Subject: [PATCH] history: refactor for a11y #341

---
 layouts/partials/menu.html |  2 +-
 static/css/ie.css          |  7 +++++--
 static/css/theme-neon.css  |  3 ++-
 static/css/theme.css       | 14 +++++++++++---
 static/css/variant.css     |  7 +++++--
 5 files changed, 24 insertions(+), 9 deletions(-)

diff --git a/layouts/partials/menu.html b/layouts/partials/menu.html
index 9b06769a3c..b7aabc5b3f 100644
--- a/layouts/partials/menu.html
+++ b/layouts/partials/menu.html
@@ -112,7 +112,7 @@
               </div>
               <script>window.variants && variants.markSelectedVariant();</script>
             </li>
-            <li class="footerVisitedLinks{{if $showvisitedlinks}} showVisitedLinks{{end}}"><a class="padding" onclick="clearHistory();"><i class="fas fa-history fa-fw"></i> {{ T "Clear-History" }}</a></li>
+            <li class="footerVisitedLinks{{if $showvisitedlinks}} showVisitedLinks{{end}}"><button class="padding" onclick="clearHistory();"><i class="fas fa-history fa-fw"></i> {{ T "Clear-History" }}</button></li>
           </ul>
         </div>
         <div id="footer" class="footerFooter{{if $showfooter}} showFooter{{end}}">
diff --git a/static/css/ie.css b/static/css/ie.css
index 29fd1effee..eb6d877ee8 100644
--- a/static/css/ie.css
+++ b/static/css/ie.css
@@ -52,6 +52,7 @@
 		font-family: "Work Sans", "Helvetica", "Tahoma", "Geneva", "Arial", sans-serif; /* var(--MAIN-font) */
 	}
 
+	.footerVisitedLinks > *,
 	a,
 	.anchor,
 	#toc-menu,
@@ -85,14 +86,16 @@
 
 	#sidebar .collapsible-menu .toggle,
 	#sidebar .select-container,
-	#sidebar a {
+	#sidebar a,
+	#sidebar button {
 		color: #bababa; /* var(--MENU-SECTIONS-LINK-color) */
 	}
 
 	#sidebar select:hover,
 	#sidebar .collapsible-menu .toggle:hover,
 	#sidebar .select-container:hover,
-	#sidebar a:hover {
+	#sidebar a:hover,
+	#sidebar button:hover {
 		color: #ffffff; /* var(--MENU-SECTIONS-LINK-HOVER-color) */
 	}
 
diff --git a/static/css/theme-neon.css b/static/css/theme-neon.css
index a04151cfdf..e2d8a36c55 100644
--- a/static/css/theme-neon.css
+++ b/static/css/theme-neon.css
@@ -177,7 +177,8 @@ body #sidebar ul.topics li.active > a {
 body #sidebar select:hover,
 body #sidebar .collapsible-menu .toggle:hover,
 body #sidebar .select-container:hover,
-body #sidebar a:hover {
+body #sidebar a:hover,
+body #sidebar button:hover {
     color: #fff;
     text-shadow:
         0 0  1px #fff,
diff --git a/static/css/theme.css b/static/css/theme.css
index f1b6f5be0e..6208f83b7d 100644
--- a/static/css/theme.css
+++ b/static/css/theme.css
@@ -206,7 +206,8 @@ th {
     margin-right: 16px;
 }
 
-#sidebar ul li a {
+#sidebar ul li a,
+#sidebar ul li button {
     display: block;
     padding: 2px 0;
 }
@@ -218,7 +219,8 @@ th {
     white-space: nowrap;
 }
 
-#sidebar ul li > a {
+#sidebar ul li > a,
+#sidebar ul li > button {
     padding: 4px 0;
 }
 
@@ -1409,8 +1411,14 @@ rapi-doc::part(section-endpoint-head-method) {
     display: initial;
 }
 
-.footerVisitedLinks a {
+.footerVisitedLinks > * {
+    -webkit-appearance: none;
+    appearance: none;
+    background: transparent;
 	cursor: pointer;
+    text-align: left;
+    text-decoration: none;
+    width: 100%;
 }
 
 @media screen and (max-width: 47.938em) {
diff --git a/static/css/variant.css b/static/css/variant.css
index 03b264fbf9..772ea4ead6 100644
--- a/static/css/variant.css
+++ b/static/css/variant.css
@@ -106,6 +106,7 @@ body {
     font-family: var(--INTERNAL-MAIN-font);
 }
 
+.footerVisitedLinks > *,
 a,
 .anchor,
 #toc-menu,
@@ -137,14 +138,16 @@ a:hover,
 
 #sidebar .collapsible-menu .toggle,
 #sidebar .select-container,
-#sidebar a {
+#sidebar a,
+#sidebar button {
     color: var(--INTERNAL-MENU-SECTIONS-LINK-color);
 }
 
 #sidebar select:hover,
 #sidebar .collapsible-menu .toggle:hover,
 #sidebar .select-container:hover,
-#sidebar a:hover {
+#sidebar a:hover,
+#sidebar button:hover {
     color: var(--INTERNAL-MENU-SECTIONS-LINK-HOVER-color);
 }